max/TugJulia
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: core adjustment to Boundary class

Browse Source 
perf: const qualification of local variables
This commit is contained in:
Max Lübke 2023-09-14 14:55:17 +02:00
parent f0d5220a48
commit edaad7cc04
2 changed files with 15 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/tug/Boundary.hpp
View File

@ -81,8 +81,8 @@ public:
double getValue(); double getValue();
private: private:
BC_TYPE type; BC_TYPE type{BC_TYPE_CLOSED};
double value; double value{-1};
}; };
/** /**

38
src/Boundary.cpp
View File

@ -1,20 +1,13 @@
#include "TugUtils.hpp" #include "TugUtils.hpp"
#include <iostream> #include <cstddef>
#include <omp.h>
#include <stdexcept> #include <stdexcept>
#include <tug/Boundary.hpp> #include <tug/Boundary.hpp>
BoundaryElement::BoundaryElement() { BoundaryElement::BoundaryElement() {}
this->type = BC_TYPE_CLOSED; BoundaryElement::BoundaryElement(double _value)
this->value = -1; // without meaning in closed case : value(_value), type(BC_TYPE_CONSTANT) {}
}
BoundaryElement::BoundaryElement(double value) {
this->type = BC_TYPE_CONSTANT;
this->value = value;
}
void BoundaryElement::setType(BC_TYPE type) { this->type = type; } void BoundaryElement::setType(BC_TYPE type) { this->type = type; }
@ -64,12 +57,9 @@ void Boundary::setBoundarySideClosed(BC_SIDE side) {
} }
} }
int n; const bool is_vertical = side == BC_SIDE_LEFT || side == BC_SIDE_RIGHT;
if (side == BC_SIDE_LEFT || side == BC_SIDE_RIGHT) { const int n = is_vertical ? grid.getRow() : grid.getCol();
n = grid.getRow();
} else {
n = grid.getCol();
}
this->boundaries[side] = std::vector<BoundaryElement>(n, BoundaryElement()); this->boundaries[side] = std::vector<BoundaryElement>(n, BoundaryElement());
} }
@ -82,13 +72,11 @@ void Boundary::setBoundarySideConstant(BC_SIDE side, double value) {
} }
} }
int n; const bool is_vertical = side == BC_SIDE_LEFT || side == BC_SIDE_RIGHT;
if (side == BC_SIDE_LEFT || side == BC_SIDE_RIGHT) { const int n = is_vertical ? grid.getRow() : grid.getCol();
n = grid.getRow();
} else { this->boundaries[side] =
n = grid.getCol(); std::vector<BoundaryElement>(n, BoundaryElement(value));
}
this->boundaries[side] = std::vector<BoundaryElement>(n, BoundaryElement(value));
} }
void Boundary::setBoundaryElementClosed(BC_SIDE side, int index) { void Boundary::setBoundaryElementClosed(BC_SIDE side, int index) {
@ -121,7 +109,7 @@ const std::vector<BoundaryElement> Boundary::getBoundarySide(BC_SIDE side) {
} }
Eigen::VectorXd Boundary::getBoundarySideValues(BC_SIDE side) { Eigen::VectorXd Boundary::getBoundarySideValues(BC_SIDE side) {
int length = boundaries[side].size(); const std::size_t length = boundaries[side].size();
Eigen::VectorXd values(length); Eigen::VectorXd values(length);
for (int i = 0; i < length; i++) { for (int i = 0; i < length; i++) {