max/iphreeqc
1
0
Fork 0
mirror of https://git.gfz-potsdam.de/naaice/iphreeqc.git synced 2025-12-16 16:44:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'ml/kinetic-names' into 'poet'

Browse Source 
refactor: Comment out unused code in KineticWrapper::names(), leading to name duplication

See merge request naaice/iphreeqc!8
This commit is contained in:
Max Lübke 2024-08-29 08:46:47 +02:00
commit bd1cbceb2c
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
poet/src/KineticWrapper.cpp
View File

@ -59,20 +59,20 @@ KineticWrapper::names(cxxKinetics *kinetics,
kin_comps.push_back(comp.Get_rate_name()); kin_comps.push_back(comp.Get_rate_name());
} }
for (const auto &kin_name : kin_comps) { // for (const auto &kin_name : kin_comps) {
auto it = std::find_if(kinetics->Get_kinetics_comps().begin(), // auto it = std::find_if(kinetics->Get_kinetics_comps().begin(),
kinetics->Get_kinetics_comps().end(), // kinetics->Get_kinetics_comps().end(),
[&](const cxxKineticsComp &comp) { // [&](const cxxKineticsComp &comp) {
return comp.Get_rate_name() == kin_name; // return comp.Get_rate_name() == kin_name;
}); // });
if (it == kinetics->Get_kinetics_comps().end()) { // if (it == kinetics->Get_kinetics_comps().end()) {
throw std::runtime_error( // throw std::runtime_error(
"Kinetic component not found in Phreeqc variables"); // "Kinetic component not found in Phreeqc variables");
} // }
names.push_back(it->Get_rate_name()); // names.push_back(it->Get_rate_name());
} // }
return names; return names;
} }