28 Commits

Author SHA1 Message Date
David Parkhurst
e3ea0100c2 vector sit_params 2021-03-15 21:10:35 -06:00
David Parkhurst
622d3618a5 vector s_x 2021-03-15 18:21:12 -06:00
David Parkhurst
de1ba62395 vector s 2021-03-15 13:21:14 -06:00
David Parkhurst
a99253764f (void)sscanf, removed SKIP, removed PHREEQ98 2021-03-12 18:11:29 -07:00
David Parkhurst
53148278fc Tony's changes; diffuse layer with pitzer 2018-08-01 17:44:32 -06:00
David Parkhurst
86a55b5b5d Tony's changes from 20180305 2018-03-07 17:08:33 -07:00
David Parkhurst
8e12139000 Fixed bug from Shell. Segv because s_list.size differed from count_s_x.
Fixed compiler warnings from jenkins.
2018-02-22 14:45:39 -07:00
David L Parkhurst
8421d08eca Updated to phreeqc3-trunk 21475
Adds some pr h2o tests.
Adds Aphi calculation for Jonathon Toner
Latest Tony tweak on PR.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/branches/concrete@12476 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2017-03-01 21:27:37 +00:00
David L Parkhurst
fb18be24e2 Tony's implementation of electric current.
Test case current1.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/branches/concrete@10550 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2015-12-08 16:54:38 +00:00
David L Parkhurst
e5a9600447 Removed dead code from pitzer
Make lists only in prep.

Fixed bug, needed to use sit_count_cations, etc.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@9809 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2015-06-09 16:16:20 +00:00
David L Parkhurst
b9b841411a Tweaking lists.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@9808 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2015-06-09 15:58:10 +00:00
David L Parkhurst
6de09799c9 Trying Pitzer lists again.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@9802 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2015-06-09 13:46:17 +00:00
David L Parkhurst
51db3a1569 Shrink array for SIT
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@9648 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2015-05-13 20:42:47 +00:00
David L Parkhurst
ef8611e0ed Switch bases for SIT.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@9637 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2015-05-11 22:20:49 +00:00
David L Parkhurst
75cce6a2a2 Do not use full pitzer for all retries in run_wrapper only number 4.
Eliminate lg rows from array if not full_pitzer.

Make lists at the end of prep (may be in error on trunk for initial solutions).

sit_revise_guesses had some bad logic, now tries to get within a factor of 2 (fail logic revised).

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/branches/sit@9614 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2015-05-08 17:52:03 +00:00
David L Parkhurst
9779f9078d Revised sit to use lists. Runs maybe 2-3 times faster.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@9579 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2015-05-05 18:09:02 +00:00
Scott R Charlton
8e9134e325 fixed crash that occurred when sit.dat was loaded twice
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@9512 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2015-04-14 00:43:12 +00:00
Scott R Charlton
9f77e000d5 fixed some of the easier clang++ scan-build bugs
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@8908 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2014-08-05 05:51:47 +00:00
David L Parkhurst
660042da0e Changed variable from max to max_cells.
Added variable all_cells to be able to initialize new cell_data.
moved old_cells, max_cells, all_cells to phreeqc class.

initialized old_cells, max_cells, all_cells in init of phreeqc class. 
Added to copy constructor.

changed logic for switching to numerical derivatives by adding && numerical_fixed_volume == false
if (iterations > 99 && numerical_fixed_volume == false)

Added 
			gammas_pz();
			jacobian_sums();
For restart in pitzer.cpp

Added 
			gammas_sit();
			jacobian_sums();
for restart in sit.cpp.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@8835 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2014-07-11 20:05:09 +00:00
Scott R Charlton
25508288fb removed set but not used variables using gcc 4.8.2[-Wunused-but-set-variable]
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@8821 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2014-07-09 01:46:43 +00:00
David L Parkhurst
7359b9dcb6 changed input_units_* to units_*.
thru GetMpiTasks
Changed GetIPhreeqcId to GetIPhreeqcPointer
added to tests RM_GetIPhreeqcId

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@8586 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2014-03-21 00:00:00 +00:00
David L Parkhurst
79698b010d Tony's fixes for Pitzer, High Pressure is still not right,
will require more fitting.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7854 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-07-23 14:51:26 +00:00
David L Parkhurst
7da9c7b1e3 Merge Tony's changes.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7844 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-07-18 15:54:14 +00:00
David L Parkhurst
7848242e28 Fixed error for malloc introduced in recent Basic function.
Fixed error with Pitzer paramenters that were not recalculated with
a change in pressure. Parameters depend on density of water I think.
Also changed SIT, although I am not sure the parameters have a pressure
dependence.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7837 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-07-17 21:15:01 +00:00
David L Parkhurst
c176fe3b2e Cleaning up code.
Removed PHREEQC2 ifdef.

Some SKIP.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7717 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-05-14 20:15:31 +00:00
David L Parkhurst
7bb4d37189 cvode
MAX_ITERS 40
   hnew = hg
   predict_fail
   CVMEM cvode_error == TRUE || predict_fail after CVnls
   if (CVMEM cvode_error == TRUE) after CVNewtonIteration
   CVDoErrorTest exit(4);

model
Phreeqc.cpp
pitzer.cpp
sit.cpp
   new status ifdef'd with NPP
   250 ms delay
   new global variable std::string string_status

!!prep: switch_bases 10 to 100 orders of mag. Need to check

utilities.cpp: new status



git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7585 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-03-29 16:03:51 +00:00
David L Parkhurst
047414274f Working on Phreeqc copy
Running ion association model with equilibrium phases
Running Pitzer.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7449 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-02-07 22:07:33 +00:00
Scott R Charlton
564a0f8af5 moved phreeqc files into src
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/branches/reorg@7308 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-01-10 06:04:12 +00:00