60 Commits

Author SHA1 Message Date
David L Parkhurst
95aa3278de Removed phrqproto.h from project and svn deleted.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5718 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-10-20 23:53:44 +00:00
David L Parkhurst
e0cbcff713 CLASS_QUALIFIER is gone, svnid gone
removed dead code from PHRQ_io.cpp


git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5714 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-10-20 21:57:51 +00:00
David L Parkhurst
7e26eec197 Last checkin svn deleted obsolete files output.h, output.cpp, phreeqc_files, main.cpp.
removed all PHREEQC_CLASS ifdefs

Need to remove old_io ifdefs

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5712 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-10-20 21:14:33 +00:00
David L Parkhurst
05495494ec Removed output.h throughout.
Will svn delete output.h, output.cpp, phreeqc_files.cpp, main.cpp.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5710 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-10-20 19:26:08 +00:00
David L Parkhurst
d57af05353 OUTPUT_MESSAGE removed, need to check a bit.
sformatf now returns char *. Should be more efficient.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5706 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-10-20 13:41:03 +00:00
David L Parkhurst
92d8a3b98a OUTPUT_CHECKLINE and OUTPUT_ECHO done.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5704 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-10-19 22:13:03 +00:00
David L Parkhurst
fe9f31443e Replaced modify_activities so that PHREEQC instance is not needed.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5677 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-10-04 21:32:25 +00:00
David L Parkhurst
d0075d7c4d Converted phrq_io to pointer rather than an instance.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5667 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-09-30 20:05:35 +00:00
David L Parkhurst
9fe532eaaf Cleaned up Get_ and Set_ except for parser.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5661 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-09-29 18:51:39 +00:00
David L Parkhurst
4d728afcbe Removed MOVE_TO_STRUCTURES ifdefs.
Removed most SKIP ifdefs

ran test cases OK.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5657 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-09-28 20:25:20 +00:00
David L Parkhurst
9efcd6ecb8 Finished all but loose ends with P_INSTANCEs.
Did Surface, charge and comp.

Now can clean up some more.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5656 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-09-28 17:05:01 +00:00
David L Parkhurst
9561576af7 Finished SSassemblage.cxx
Cleaned up other files some.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5655 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-09-27 23:36:52 +00:00
David L Parkhurst
62a55134be Worked through solution removing PHREEQC_PTR_ARG.
More cleaning up to do.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5653 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-09-27 21:18:38 +00:00
David L Parkhurst
02ab5c208c Finished PPassemblage and Reaction P_INSTANCE removal.
Removed some commented PHREEQC_PTR_ARG from headers.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5652 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-09-27 19:59:49 +00:00
David L Parkhurst
2dab6f8ed8 Removed PHREEQC_PTR_ARG from gas phase and temperature.
Removed commented PHREEQC_PTR from some of the header files.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5651 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-09-27 17:15:14 +00:00
David L Parkhurst
06f4e08ecf Finished with Exchange removing all P_INSTANCE I think.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5650 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-09-27 15:54:10 +00:00
David L Parkhurst
7c9913195a Worked through kinetics to remove PHREEQC_PTR.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5649 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-09-26 22:56:22 +00:00
David L Parkhurst
12d62e8e54 Removed P_INSTANCE for error_msg, which removed entirely from
some methods.

Began moving xx2struct into phreeqc from class definitions.

First moved was cxxMix2mix to structures.c.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5648 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-09-26 20:24:17 +00:00
David L Parkhurst
b7729cf254 Changed all check of input_error to get_input_errors for phreeqc.
Started removing PHREEQC_PTR and P_INSTANCE. Redid all read_raw.

Breaks some echoing or printing of output. Need to check why.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5646 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-09-23 22:33:19 +00:00
David L Parkhurst
50b369a294 Compiles all configurations of phreeqcpp.vcproj
Does not use callbacks.

Uses phrq_io instance of PHRQ_io.

I am sure it will not compile as plain phreeqc without modification.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5640 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-09-22 00:08:29 +00:00
David L Parkhurst
7eeeab4569 all classes inherit from PHRQ_base, except
NameDouble, StorageBinListItem.

NumKeyword inherits from PHRQ_base, others inherit NumKeyword.

ChartHandler and ChartObject inherit from PHRQ_base.

CurveObject does not inherit from PHRQ_base.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5637 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-09-20 20:05:43 +00:00
David L Parkhurst
f6ed50af7e Added base to kinetics, mix, and exchange.
Going in alphabetical order in src.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5629 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-09-09 22:32:09 +00:00
David L Parkhurst
aba479648c Added file_on variables to PHRQ_io.
Set dump, log, and punch file_on variables whereever
pr.dump, pr.log, and pr.punch were set in PHREEQC.

Added base class to Solution, ISolution, and StorageBin. Required a PHRQ_io in the constructor to find all places they were constructed.

Need to do the same to all other classes (Exchange, Surface, NameDouble, etc.)

Then need to take PHREEQC instance out of parser and fix all places a parser is constructed.

Need to move phreeqc2class constructors to phreeqc.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@5628 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-09-09 22:05:32 +00:00
David L Parkhurst
2b11772777 Rewrote run_cells to do all of the calculations that would be
done if a series of USE and SAVE.

Modified the logic when time step is defined in run_cells. Equivalent to time_step in nmax steps, where nmax is max steps
in kinetics, reaction, reaction_temperature.

Wrote dump for chart and chart_handler. chart_handler calls dump for all user_graph.

Fixed bug in chart_object with log definition. Had wrong logic when looking for t/T/l/L.

initial_total_time initialized twice in mainsubs and twice in phreeqc.cpp.

Fixed heading logic for mixing graph_x, graph_y, graph_sy with plot_xy.

Moved NA to header file.


git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@5431 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-06-10 22:00:46 +00:00
David L Parkhurst
2a491b71a4 merged MULTICHART branch back to trunk
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@5365 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-05-04 00:24:40 +00:00
David L Parkhurst
e746bb8e07 Added code to adjust activities of master species in solution when totals are adjusted by SOLUTION_MODIFY.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@5270 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2011-03-30 19:21:36 +00:00
David L Parkhurst
75e0df6e1a Through REACTION_MODIFY and REACTION_RAW.
Added REACTION_MODIFY for completeness.

Fixed bugs in ReadClass.cxx where alpha for id number 
caused an endless loop.

Also fixed some error messages where line_save was no
longer meaningful.



git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@4857 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2010-09-30 22:18:39 +00:00
David L Parkhurst
3c28075164 exchange_modify, recalculate formula_totals after redefinition.
changed pitzer_exchange_gammas to exchange_gammas.

Fixed null pointer in prep.c

Tidy equilibirium phases after equilibirium_phases_modify, but not other reactants. For equilibrium phases, recalculates an element list.

input.fm throug exchange_modify.


git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@4831 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2010-09-22 17:17:38 +00:00
David L Parkhurst
11b0315dd8 Made pitzer_exchange_gammas true the default.
Fixed up read_input to use correct keyword numbers. Updated tidy to tidy the appropriate data blocks when _modify blocks are read. 

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@4830 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2010-09-21 20:58:42 +00:00
David L Parkhurst
aa5cafeadd Use OPTION_KEYWORD for stremify
KEYWORD for check_line.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@4827 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2010-09-20 16:04:46 +00:00
David L Parkhurst
d34b328b06 Added -cell to dump, copy, delete.
Selects anything with the specified user numbers.

Fixed bug in read_class where end of file caused the
last line of input to be repeated in the output.

removed warning print from copy_entities, which is nicer 
for copy -cell and some reactants are not present.

rewrote read_copy to include -cell, but also changed logic
for selection of appropriate keywords. Now has list that are acceptable, whereas before it was a list of unacceptable.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@4823 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2010-09-17 21:39:00 +00:00
David L Parkhurst
b1fca87a57 Added -mix, -reaction, -temperature, -cells to DUMP.
Added warning for use of REACTION and kinetics.



git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@4800 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2010-09-08 20:33:43 +00:00
Scott R Charlton
4d050487e4 added prototypes for dump routines; added ostream header
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@4197 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2010-03-29 21:56:51 +00:00
Scott R Charlton
a22a6db097 need to test on linux
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@4165 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2010-03-18 03:21:45 +00:00
David L Parkhurst
65ff0a9456 Fixed Makefile on Linux to make class version.
Added eol and other changes for linux.

Had statics in ReadClass.cxx, removed.

Problems with .dmp files. May be because of statics.




git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@3879 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2009-12-08 23:58:06 +00:00
David L Parkhurst
3131740cfb Compiles as class, debug, and Release.
Requires recompilation of the entire solution for some reason.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@3878 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2009-12-08 22:12:42 +00:00
David L Parkhurst
9f4eefd214 Made all the changes to add phreeqc pointer as argument to
Phreeqcpp class methods.

Still compiles on Debug and Release, but problem with
phrq_malloc in cvdense and cvode.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@3876 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2009-12-08 18:09:39 +00:00
David L Parkhurst
6859605bc2 Debug and release compile.
Rearranged pitaer.h creating pitzer_structures.h.

Need to figure out conversion routines from C++ classes to C structures.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@3869 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2009-12-07 21:33:07 +00:00
David L Parkhurst
2b76f04a8b Cleaned up header files to remove unnecessary includes of .h files. Moved includes to source code where possible.
Moved some methods for .h to source files to avoid need for includes.

Debug and Release compile. 

Still need to get class version working. 

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@3868 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2009-12-07 19:49:38 +00:00
David L Parkhurst
3fe2fcd3bb Modified to run_cells if solution exists, even with no reactants.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@3824 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2009-12-02 15:45:49 +00:00
Scott R Charlton
303864120a updated for COM object
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@3749 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2009-11-03 23:39:32 +00:00
David L Parkhurst
c73fc4b2e9 Modifications for Linux.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@3736 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2009-11-02 15:34:29 +00:00
David L Parkhurst
259c0839f0 Added new class runner.
Finished new keyword RUN_CELLS.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@3730 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2009-10-30 22:27:43 +00:00
David L Parkhurst
cd38a8036d Have done preliminary testing with all MODIFY keywords.
Added brief documentation in revisions.

Fixed dump feature of TRANSPORT to work with
dump_raw of C++.

ppdump now has testing for DUMP, DELETE, and MODIFY.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@3727 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2009-10-29 19:53:35 +00:00
David L Parkhurst
d54c04039a Have converted std::list to std::map for all entities.
surface is completed but needs testing.

SS and kinetics need to have reread of components implemented for MODIFY option.

gas_phase may be done, needs to be tested.



git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@3726 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2009-10-28 19:15:17 +00:00
David L Parkhurst
f015759286 exchange_modify is working.
changed list of comps to map of comps.

made sure that description changes were captured for solution, equilibrium_phases, and exchange.

surface is next.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@3725 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2009-10-27 22:57:49 +00:00
David L Parkhurst
b9e38f4da8 Updated phreeqcpp to have examples from phreeqc.
equilibrium_phases_read_raw has duplicate lines.




git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@3724 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2009-10-27 20:29:04 +00:00
David L Parkhurst
cbfb768381 Initial testing of SOLUTION_MODIFY and EQUILIBRIUM_PHASES_MODIFY.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@3721 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2009-10-27 16:38:25 +00:00
David L Parkhurst
2fd35ce463 Delete, Dump seem to work.
SOLUTION_MODIFY seems to work, but need to check all features.

EQUILIBRIUM_PHASES_MODIFY fails. Need to use maps to allow update I think. 

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@3719 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2009-10-23 00:03:23 +00:00
David L Parkhurst
79092e94b4 Have added delete, but parser is not working correctly. Am going back to 3705 to see if it worked correctly then.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/trunk@3716 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2009-10-22 19:24:31 +00:00