119 Commits

Author SHA1 Message Date
David L Parkhurst
9bf1411f42 Updated to PHREEQC3 12386
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/branches/concrete@12387 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2017-02-09 16:41:47 +00:00
David L Parkhurst
03c9d56c09 Tony's updates to allow fixed current.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/branches/concrete@11133 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2016-05-03 16:27:32 +00:00
David L Parkhurst
4405e60e4e Merged source up to phreeqc3-trunk SVN 10892
copied files from trunk and merged changes manually.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/branches/concrete@10893 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2016-03-04 18:13:43 +00:00
David L Parkhurst
174c739d26 Updated concrete source from concrete_parallel source (not using parallel).
Now going to run test cases on Linux.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/branches/concrete@10719 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2016-01-20 18:12:15 +00:00
David L Parkhurst
301d2d009c transport.cpp, ifdefd old viscosity, initialized variables; basicsubs call viscosity();phreeqc, revert ineq_tol
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/branches/concrete@10569 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2015-12-14 20:35:26 +00:00
David L Parkhurst
fb18be24e2 Tony's implementation of electric current.
Test case current1.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/branches/concrete@10550 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2015-12-08 16:54:38 +00:00
Scott R Charlton
6e752e26c4 windows java working with callback
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@10300 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2015-09-24 06:10:03 +00:00
David L Parkhurst
a6d63e33b5 Commented dead code related to density of water in Pitzer.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@9396 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2015-03-25 16:47:42 +00:00
David L Parkhurst
e036c2c40c Added logic to run only one step in RunCells
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@8951 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2014-09-12 22:11:27 +00:00
David L Parkhurst
660042da0e Changed variable from max to max_cells.
Added variable all_cells to be able to initialize new cell_data.
moved old_cells, max_cells, all_cells to phreeqc class.

initialized old_cells, max_cells, all_cells in init of phreeqc class. 
Added to copy constructor.

changed logic for switching to numerical derivatives by adding && numerical_fixed_volume == false
if (iterations > 99 && numerical_fixed_volume == false)

Added 
			gammas_pz();
			jacobian_sums();
For restart in pitzer.cpp

Added 
			gammas_sit();
			jacobian_sums();
for restart in sit.cpp.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@8835 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2014-07-11 20:05:09 +00:00
David L Parkhurst
e4229340b0 fixed memory leaks.
commented lines are directives for visual studio _CRTDBG_MAP_ALLOC, _CrtSetDbgFlag
VarClear in GetSelectedOutputHeading.
RebalanceLoadPerCell fixed for serial version, clear clock times.
delete out stream and punch stream before new, RunCells
  also set streams to NULL after deleted.
  also serial version.
VarClear in RunCellsThreadNoPrint
timing only if rebalance cell, RunCellsThreadNoPrint
VarClear in RunCellsThread.
changed methods to return pointer instead of reference, Get_out_stream
~IPhreeqcPhast, delete streams if necessary.
phast_manager did not delete module for flow-only.
phast_worker did not delete module for flow-only.

return pointers:
Get_out_stream
Get_punch_stream

IPhreeqc, 
delete default_data_base and sformatf_buffer in clean_up, not in operator = or ~phreeqc 

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@8784 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2014-06-10 23:51:13 +00:00
David L Parkhurst
0ff6f4815f Fixed bug with 18O, redox states not defined in default.
Also, the logic for using -isotopes data was changed so that the last defined applies to all remaining solutions.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@8741 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2014-05-12 18:07:46 +00:00
David L Parkhurst
c43019c496 Roughing in mcd capability.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@8536 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2014-02-28 21:29:53 +00:00
David L Parkhurst
9d9e86f875 Added next_user_number to Phreeqc.
Added a template function Rxn_next_user_number.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@8397 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2014-01-24 00:34:03 +00:00
David L Parkhurst
9048a9be86 Bugs fixes noted by Marco De-Vroed
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@8371 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2014-01-14 20:42:12 +00:00
Scott R Charlton
adf7d98498 Merged revision(s) 7863-7986 from phreeqc3/branches/multi_punch:
Branching at 7862 for multiple SELECTED_OUTPUT, USER_PUNCH
........
Have multiple SELECTED_OUTPUT working.

Need to have multiple USER_PUNCH.
........
Think multiple instances of both SELECTED_OUTPUT and USER_PUNCH are working.
........
Fixed up inverse.cpp a bit.
........
Fixed missing -pressure in solution dump_raw and read_raw.
........
Merging revisedfandg back into trunk. Makes Excel spreadsheet for carbon-14 dating.

OK by Niel. Has Revised_Fontes_ and_Garnier_ in_NetpathXL.docx to add for documentation.
........
Added Revised_Fontes_ and_Garnier_ in_NetpathXL.docx to installation
Fixed bug that wouldn't allow uninstall
........
updated ftp targets
........
NetpathXL 1.4
........
checkin from make
........
latest test with change in Pitzer pressure, -pressure in SOLUTION_RAW, runs modify_test, has error
........
bugs linux caught, something different about when to print headings
........
Working on multipunch
........
working on high_precision, using SELECTED_OUTPUT 1
........
dump precision
........
Added basic functions:
EQ_FRAC
KIN_TIME
SPECIES_FORMULA
STR_F
STR_E
Added //{{NEW BASIC HERE}} for updating BASIC routines

........
Making backward compatible.

Copying all but lists.

Revised tidy_punch logic.
........
Still working to make backward compatible.

Think there will be one diff, headings will not be rewritten (ddl_flux).
........
updated dump tests (new -pressure line)
........
multi_punch branch

........
Added a Fortran callback.

Will try to revise so that the same callback works for Fortran and C.
........
Revised name to BasicFortran

Added methods for C call SetBasicCallback.

Need to check C side and documentation.
........


git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7987 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-08-28 23:11:07 +00:00
David L Parkhurst
30164dc7fd functions are fcn
Added cookie to c callback.



git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7895 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-08-08 19:53:31 +00:00
David L Parkhurst
ca3e1128a2 Initialize basic_callback_ptr
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7890 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-08-07 19:46:57 +00:00
David L Parkhurst
346cf2239b Added a Fortran callback.
Will try to revise so that the same callback works for Fortran and C.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7883 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-08-05 18:56:31 +00:00
David L Parkhurst
ce4284a561 working on high_precision, using SELECTED_OUTPUT 1
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/branches/multi_punch@7876 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-08-01 22:48:14 +00:00
David L Parkhurst
3893414278 Think multiple instances of both SELECTED_OUTPUT and USER_PUNCH are working.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/branches/multi_punch@7865 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-07-31 23:07:07 +00:00
David L Parkhurst
276322a936 Have multiple SELECTED_OUTPUT working.
Need to have multiple USER_PUNCH.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/branches/multi_punch@7864 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-07-31 19:26:34 +00:00
David L Parkhurst
7da9c7b1e3 Merge Tony's changes.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7844 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-07-18 15:54:14 +00:00
David L Parkhurst
7848242e28 Fixed error for malloc introduced in recent Basic function.
Fixed error with Pitzer paramenters that were not recalculated with
a change in pressure. Parameters depend on density of water I think.
Also changed SIT, although I am not sure the parameters have a pressure
dependence.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7837 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-07-17 21:15:01 +00:00
David L Parkhurst
c176fe3b2e Cleaning up code.
Removed PHREEQC2 ifdef.

Some SKIP.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7717 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-05-14 20:15:31 +00:00
David L Parkhurst
47d0c62fc3 Added new Basic function kin_time, which is the time interval for the current kinetic integration.
kin_delta/kin_time is the average rate over the time interval.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7676 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-05-01 16:14:16 +00:00
David L Parkhurst
24ed8b5cc0 Tony's changes for gases.
Removes some more 's.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7653 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-04-26 16:57:25 +00:00
David L Parkhurst
e60d708c84 Some of Tony's changes that I missed.
Removed some but not all '

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7652 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-04-26 14:26:24 +00:00
David L Parkhurst
7bb4d37189 cvode
MAX_ITERS 40
   hnew = hg
   predict_fail
   CVMEM cvode_error == TRUE || predict_fail after CVnls
   if (CVMEM cvode_error == TRUE) after CVNewtonIteration
   CVDoErrorTest exit(4);

model
Phreeqc.cpp
pitzer.cpp
sit.cpp
   new status ifdef'd with NPP
   250 ms delay
   new global variable std::string string_status

!!prep: switch_bases 10 to 100 orders of mag. Need to check

utilities.cpp: new status



git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7585 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-03-29 16:03:51 +00:00
David L Parkhurst
1342a5c580 Alternate method for sum_species
fixed memory leak when copying phreeqc instance with llnl.dat

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7473 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-02-19 19:40:11 +00:00
David L Parkhurst
3461797c95 Copied Advection and Transport data in InternalCopy.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7472 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-02-19 18:13:43 +00:00
David L Parkhurst
916ccdafa8 Working on copy operator.
Fixing problems with iso.dat.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7454 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-02-08 23:02:14 +00:00
David L Parkhurst
6412a827dd Forgot to copy sit_param
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7453 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-02-08 21:20:33 +00:00
David L Parkhurst
047414274f Working on Phreeqc copy
Running ion association model with equilibrium phases
Running Pitzer.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7449 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-02-07 22:07:33 +00:00
Scott R Charlton
4cb545599e added some UNREFERENCED_PARAMETER;
removed g_spread_sheet

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7422 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-01-31 05:06:34 +00:00
David L Parkhurst
c8c26e81e9 Tony's new Pitzer test cases
Updated Run_salt.bat
Updated Makefile

Tony's changes through 20130129a

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7400 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2013-01-29 16:37:25 +00:00
David L Parkhurst
03b0b8848c Remove Dictionary, Linux changes
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7051 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2012-10-30 18:36:59 +00:00
David L Parkhurst
ed73e17fd8 Working on copy constructor. Roughed in Pitzer, need to do Sit and TRANSPORT. Test
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7009 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2012-10-11 23:30:56 +00:00
David L Parkhurst
e3638b346c Revised phreeqc constructor, init, and initialize.
All data members are now initialized in init.
Almost all allocation is in initialize.
There is a little bit of duplication in initialize, but not much.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@7005 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2012-10-11 00:39:07 +00:00
David L Parkhurst
8823f0ff2f Added STATIC_VOPTS to make vopts static, not static unless defined.
Guy had problems with static variables with OpenMP.

Also removed other static variables fpunchf_user s_warning and buffer, spread length, utilities spinner. Put in Phreeqc.h.

Removed static fnbuf from Pbasic.cpp, put in Pbasic.h.

I think only static variables are in Keywords.h and are necessary for initialization.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@6770 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2012-07-11 16:23:02 +00:00
David L Parkhurst
8e0844ed26 Fixed memory all memory leaks from mytest.
Modified ss_r to run on Windows.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@6475 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2012-04-13 17:08:59 +00:00
David L Parkhurst
bf96306cba output file was closed before free_all, no messages appeared.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@6466 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2012-04-12 18:10:01 +00:00
Scott R Charlton
ae7c893c88 added initialization code
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@6360 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2012-04-04 05:07:46 +00:00
Scott R Charlton
69711a425a made iso_defaults public and static
This is really just 6324 without deleting Phreeqc.h and keeping the history. In order
to keep the history you need to do a reverse merge.

see http://stackoverflow.com/questions/2863028/recover-a-folder-or-file-in-tortoisesvn-whilst-also-retaining-all-history

answer attached:

Do a "reverse merge":
 1.Ensure that your working copy is updated to HEAD and completely clean (not strictly necessary, but always a good idea before trying to merge)
 2.Right click on the folder and select TortoiseSVN > Merge...
 3.Select "Merge a range of revisions" and hit "Next"
 4.The URL to merge from is the repo path for your current directory (ie. the one containing the deleted file)
 5.The revision range to merge is the revision in which you deleted the file (show log might help here)
 6.Be sure to select "Reverse merge"
 7.Hit "Next"
 8.All the default merge options should be sufficient, so hit "Merge"
 
The file should now be added and still retain all of its previous history.

Explanation:

This "rolls back" the revision containing the deletion, but adds the merge information to the directory properties. SVN can track the original file through this metadata. On the command line you would to do a backwards merge of the revision in which you deleted it:
svn merge -c -<revision-number> path/containing/file

Note the hyphen before the rev number (ie. a "negative" revision nunber).
 

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@6328 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2012-03-30 22:36:01 +00:00
Scott R Charlton
96294247ac trying to fix loss of history with Phreeqc.h
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@6327 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2012-03-30 22:24:25 +00:00
Scott R Charlton
3df08dd0f1 made iso_defaults public and static
git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@6324 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2012-03-30 21:49:57 +00:00
David L Parkhurst
91f650a5e9 Merged ErrorHandling 6119-6268 changes.
All reactant structs have been removed.
Tony's pressure uses mu in pressure term of log_k.
Test cases run, discriminant check at 1e-8.

Still want to optimize out some k_temp calls and checks for same T, P, mu.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqc3/trunk@6269 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2012-03-06 23:42:49 +00:00
David L Parkhurst
dd06c2eaf2 Runs most kinetics, kinsurf is a problem.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@6084 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2012-01-20 00:56:16 +00:00
David L Parkhurst
18906cdd2f Removed skipped code.
git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@6081 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2012-01-18 17:23:36 +00:00
David L Parkhurst
d051a77711 compiles and runs solid_solution test case.
Need to compile on Linux and run all test cases.

git-svn-id: svn://136.177.114.72/svn_GW/phreeqcpp/branches/ErrorHandling@6070 1feff8c3-07ed-0310-ac33-dd36852eb9cd
2012-01-17 20:39:32 +00:00