max/tug
1
0
Fork 0
mirror of https://git.gfz-potsdam.de/naaice/tug.git synced 2025-12-13 09:28:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

change: all variables as pass by reference

Browse Source
This commit is contained in:
Hannes Signer 2023-08-03 14:57:44 +02:00
parent 70268f58f3
commit d38e14d6f4
6 changed files with 22 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
examples/reference-FTCS_2D_closed.cpp
View File

@ -1,5 +1,8 @@
#include <tug/Simulation.hpp>
#include "Eigen/Core"
#include <iostream>
using namespace std;
int main(int argc, char *argv[]) {
int row = 11;
@ -50,4 +53,6 @@ int main(int argc, char *argv[]) {
// RUN
sim.run();
cout << grid.getConcentrations() << endl;
}

8
include/tug/Simulation.hpp
View File

@ -37,7 +37,7 @@ class Simulation {
* @param bc
* @param aproach
*/
Simulation(Grid grid, Boundary bc, APPROACH approach);
Simulation(Grid &grid, Boundary &bc, APPROACH approach);
/**
* @brief
@ -107,7 +107,7 @@ class Simulation {
*
* @return Grid
*/
Grid run();
void run();
private:
@ -117,8 +117,8 @@ class Simulation {
CONSOLE_OUTPUT console_output;
TIME_MEASURE time_measure;
Grid grid;
Boundary bc;
Grid &grid;
Boundary &bc;
APPROACH approach;
};

11
src/FTCS.cpp
View File

@ -239,7 +239,7 @@ MatrixXd FTCS_1D(Grid &grid, Boundary &bc, double &timestep) {
}
MatrixXd FTCS_2D(Grid &grid, Boundary &bc, double &timestep) {
void FTCS_2D(Grid &grid, Boundary &bc, double &timestep) {
int rowMax = grid.getRow();
int colMax = grid.getCol();
double deltaRow = grid.getDeltaRow();
@ -384,17 +384,16 @@ MatrixXd FTCS_2D(Grid &grid, Boundary &bc, double &timestep) {
)
;
return concentrations_t1;
grid.setConcentrations(concentrations_t1);
}
MatrixXd FTCS(Grid &grid, Boundary &bc, double &timestep) {
void FTCS(Grid &grid, Boundary &bc, double &timestep) {
if (grid.getDim() == 1) {
return FTCS_1D(grid, bc, timestep);
FTCS_1D(grid, bc, timestep);
} else {
return FTCS_2D(grid, bc, timestep);
FTCS_2D(grid, bc, timestep);
}
}

10
src/Simulation.cpp
View File

@ -10,9 +10,7 @@
using namespace std;
Simulation::Simulation(Grid grid, Boundary bc, APPROACH approach) : grid(grid), bc(bc) {
//probably to DEBUG assignment of grid and bc
this->grid = grid;
Simulation::Simulation(Grid &grid, Boundary &bc, APPROACH approach) : grid(grid), bc(bc) {
this->approach = approach;
//TODO calculate max time step
@ -146,7 +144,7 @@ void Simulation::printConcentrationsCSV(string filename) {
file.close();
}
Grid Simulation::run() {
void Simulation::run() {
string filename;
if (this->console_output > CONSOLE_OUTPUT_OFF) {
printConcentrationsConsole();
@ -165,7 +163,7 @@ Grid Simulation::run() {
printConcentrationsCSV(filename);
}
grid.setConcentrations(FTCS(grid, bc, timestep));
FTCS(grid, bc, timestep);
}
} else if (approach == BTCS_APPROACH) {
@ -191,5 +189,5 @@ Grid Simulation::run() {
printConcentrationsCSV(filename);
}
return grid;
}

2
test/CMakeLists.txt
View File

@ -11,7 +11,7 @@ if(NOT DOCTEST_LIB)
FetchContent_MakeAvailable(DocTest)
endif()
add_executable(testTug setup.cpp testBoundaryCondition.cpp testDiffusion.cpp testSimulation.cpp)
add_executable(testTug setup.cpp testSimulation.cpp) # testBoundaryCondition.cpp testDiffusion.cpp
target_link_libraries(testTug doctest tug)
# get relative path of the CSV file

8
test/testSimulation.cpp
View File

@ -49,19 +49,17 @@ static Grid setupSimulation() {
Simulation sim = Simulation(grid, bc, FTCS_APPROACH);
sim.setTimestep(0.001);
sim.setIterations(7000);
// sim.setOutputCSV(CSV_OUTPUT_ON);
// sim.setOutputConsole(CONSOLE_OUTPUT_ON);
sim.run();
// RUN
return sim.run();
return grid;
}
TEST_CASE("equality to reference matrix") {
// set string from the header file
string test_path = testSimulationCSVDir;
MatrixXd reference = CSV2Eigen(test_path);
cout << test_path << endl;
Grid grid = setupSimulation();
CHECK(checkSimilarity(reference, grid.getConcentrations(), 0.1) == true);
}